fix: Remove dead __BUILTINS__ constant#461
Merged
Merged
Conversation
jsonbailey
marked this pull request as ready for review
July 17, 2026 15:04
keelerm84
approved these changes
Jul 17, 2026
jsonbailey
force-pushed
the
jb/sdk-2692/remove-dead-builtins
branch
from
July 17, 2026 16:07
f42c964 to
91f032a
Compare
jsonbailey
force-pushed
the
jb/sdk-2692/remove-dead-builtins
branch
from
July 17, 2026 16:36
91f032a to
461e621
Compare
jsonbailey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the dead module-level
__BUILTINS__constant from its three locations — referenced nowhere:ldclient/impl/evaluator_common.pyldclient/impl/util.pyldclient/__init__.pyWhy
It went dead in
1d9769b("prepare 8.0.0 release", 2022-12-30): the contexts migration deleted its only consumer (_get_user_attribute) but left the definition behind — an incidental missed cleanup. It has had no readers since.Non-breaking
Not in any
__all__, not imported or re-exported anywhere, uses the private__NAME__convention, and zero references across the tree. No public API change; no major version bump. (Surfaced while auditing the evaluator sync/async duplication in #460.)Validation
uv run mypy ldclient— cleanuv run pytest ldclient/testing/impl/test_evaluator.py ldclient/testing/impl/test_util.py— 20 passedimport ldclientsmoke — OKSDK-2692 (epic SDK-60).
Note
Low Risk
Dead-code removal with no public API or evaluator behavior changes; only a documentation comment on logging.
Overview
Deletes the dead
__BUILTINS__module constants fromldclient/__init__.py,ldclient/impl/evaluator_common.py, andldclient/impl/util.py. Those lists were left over after the contexts migration and are not referenced anywhere in the tree.In
ldclient/impl/util.py, adds a short comment on theldclient.utillogger name, pointing to SDK-2696 for a future cleanup.Reviewed by Cursor Bugbot for commit 461e621. Bugbot is set up for automated code reviews on this repo. Configure here.